Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v0.47.x] don't return validation error when taskrun failed/skipped #6688

Merged
merged 1 commit into from
May 19, 2023
Merged

[release-v0.47.x] don't return validation error when taskrun failed/skipped #6688

merged 1 commit into from
May 19, 2023

Conversation

tekton-robot
Copy link
Collaborator

This is an automated cherry-pick of #6395

/assign pritidesai

If taskrun fails and task results not emitted, pipelinerun fails because of taskrun fails rather than results validation error.

@Yongxuanzhang
don't return validation error when taskrun failed/skipped
4f35e7c 
This commit aims to fix tektoncd#6383, tektoncd#6139 and supports tektoncd#3749. This commits
skip the validation if the taskrun is not successful (e.g. failed or skipped) and
omit the pipelinerun coresponding result. This way the skipped taskrun
won't get validation error for pipelinerun. And the pipelinerun error
won't be overwritten by the validation error.

Signed-off-by: Yongxuan Zhang [email protected]
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 18, 2023
@tekton-robot tekton-robot mentioned this pull request May 18, 2023
Merged
7 tasks
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 18, 2023
@tekton-robot
Copy link
Collaborator Author

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 89.2% 89.1% -0.1
pkg/reconciler/pipelinerun/resources/apply.go 98.1% 98.1% 0.0

@tekton-robot
Copy link
Collaborator Author

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 89.2% 89.1% -0.1
pkg/reconciler/pipelinerun/resources/apply.go 98.1% 98.1% 0.0

@pritidesai
Copy link
Member

/kind bug

@pritidesai pritidesai closed this May 18, 2023
@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label May 18, 2023
@pritidesai pritidesai reopened this May 18, 2023
@tekton-robot
Copy link
Collaborator Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pritidesai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2023
@tekton-robot
Copy link
Collaborator Author

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 89.2% 89.1% -0.1
pkg/reconciler/pipelinerun/resources/apply.go 98.1% 98.1% 0.0

@tekton-robot
Copy link
Collaborator Author

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 89.2% 89.1% -0.1
pkg/reconciler/pipelinerun/resources/apply.go 98.1% 98.1% 0.0

@JeromeJu
Copy link
Member

/retest

1 similar comment
@JeromeJu
Copy link
Member

/retest

@Yongxuanzhang
Copy link
Member

/test pull-tekton-pipeline-go-coverage-df

@tekton-robot
Copy link
Collaborator Author

@Yongxuanzhang: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-beta-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test pull-tekton-pipeline-go-coverage-df

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Yongxuanzhang
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2023
@tekton-robot tekton-robot merged commit 61d05a7 into tektoncd:release-v0.47.x May 19, 2023
@tekton-robot
Copy link
Collaborator Author

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 89.2% 89.1% -0.1
pkg/reconciler/pipelinerun/resources/apply.go 98.1% 98.1% 0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pritidesai pritidesai pritidesai approved these changes

@lbernick lbernick Awaiting requested review from lbernick

@wlynch wlynch Awaiting requested review from wlynch

Assignees

@pritidesai pritidesai

@Yongxuanzhang Yongxuanzhang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tekton-robot @pritidesai @JeromeJu @Yongxuanzhang